fix: Pull Query Key Extraction Optimizations #8346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hli21
changed the title
hli21
changed the title
AlanConfluent
approved these changes
Nov 16, 2021
| @@ -577,6 +582,34 @@ private Object resolveKey( | |||
| FormatOptions.noEscape()))) | |||
| .orElse(null); | |||
| } | |||
|
|
|||
| private void getConstraint( | |||
There was a problem hiding this comment.
This method name is a bit vague and sounds like a getter. Maybe call it setMostSelectiveConstraint or something like that? It would also be good to add a comment about what this does.
| assertThat(keys.size(), is(1)); | ||
| assertThat(keys.get(0), instanceOf(KeyConstraint.class)); | ||
| final KeyConstraint keyConstraint = (KeyConstraint) keys.get(0); | ||
| assertThat(keyConstraint.getKey(), is(GenericKey.genericKey(3))); |
There was a problem hiding this comment.
Want to check the operator to show that you have the equals as well? Finding a three probably indicates that the one you got, but good to be sure.
| assertThat(keys.size(), is(1)); | ||
| assertThat(keys.get(0), instanceOf(KeyConstraint.class)); | ||
| final KeyConstraint keyConstraint = (KeyConstraint) keys.get(0); | ||
| assertThat(keyConstraint.getKey(), is(GenericKey.genericKey("v2"))); |
There was a problem hiding this comment.
Would be great to check the operator here and elsewhere too just to be sure we didn't accidentally swap them with other key values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Optimize the key constraint extraction logic.
This problem was reported in issue #6973
Testing done
Add new unit tests.
Reviewer checklist