fix: Improving error messages #9637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnh5y
reviewed
Oct 10, 2022
ksqldb-parser/src/main/java/io/confluent/ksql/parser/SyntaxErrorValidator.java
Outdated
Show resolved
Hide resolved
jnh5y
reviewed
Oct 10, 2022
ksqldb-parser/src/test/java/io/confluent/ksql/parser/KsqlParserTest.java
Outdated
Show resolved
Hide resolved
|
Hmm... the Did you try updating that particular QTT? |
I just tried it and unfortunately it could not catch the exception as well :( |
jnh5y
approved these changes
Oct 11, 2022
There was a problem hiding this comment.
@aliehsaeedii Looks good. I was able to add a QTT.
Does that look reasonable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issue #8952
Description
Creating a source on an already existing Kafka topic with a defined schema requires adding VALUE_SCHEMA_ID in the WITH clause. Otherwise INSERT INTO fails with an ambiguous error message as explained here. This fix adds a hint to the error message for an easier debugging.
Testing done
Manual Testing
QTT is not able to cover this case.
Reviewer checklist