[KIP-86] Implements rd_kafka_sasl_set_credentials #4033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josvisser66
changed the title
edenhill
reviewed
Nov 1, 2022
CHANGELOG.md
Outdated
|
|
||
| librdkafka v1.9.4 is a maintenance release: | ||
|
|
||
| * Added rd_kafka_sasl_set_credentials API function to set or reset the SASL PLAIN or SCRAM credentials used for new broker connections. |
There was a problem hiding this comment.
This should go in the v1.9.3 section below - that's the next release.
Add it to the Enhancement chapter
Try to stick below 80 columns
Co-authored-by: Jos Visser <jvisser@confluent.io> Co-authored-by: edenhill <magnus@edenhill.se>
edenhill
approved these changes
Nov 8, 2022
|
Thanks Jos! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new API call rd_kafka_sasl_set_credentials which can be used to set or reset the credentials used for SASL PLAIN or SCRAM in a Kafka client. This is useful for environments that want to change their credentials (e.g. because the old credentials are going to expire) without destroying the Kafka client. The new credentials will be used the next time the Kafka client needs to make a new connection to a broker. Setting these credentials using the new API call will not break any connections that were set up using the old credentials.
Note: Although this is not the same as KIP-86, it allows for the same sort of behavior as KIP-86.