Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix segfault when a fetch from follower lease expires #4254

Merged
merged 3 commits into from
Apr 19, 2023

Conversation

emasab
Copy link
Contributor

@emasab emasab commented Apr 13, 2023

and the partition is waiting for
a list offsets result

closes #4195

@emasab emasab force-pushed the dev_fix_fetch_from_follower_offset_retry branch from 742f262 to 2b2c91b Compare April 13, 2023 15:00
@emasab emasab changed the title Fix segfault when a fetch from follower Fix segfault when a fetch from follower lease expires Apr 13, 2023
Copy link
Contributor

@milindl milindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on discussion yesterday, that this assert should never be there

fetch from follower lease expires
and the partition is waiting for
a list offsets result
lease expires and the partition is waiting for
a list offsets result

closes #4195
@emasab emasab force-pushed the dev_fix_fetch_from_follower_offset_retry branch from 2b2c91b to f7a9335 Compare April 19, 2023 14:21
@emasab emasab merged commit 3de70e4 into master Apr 19, 2023
@emasab emasab deleted the dev_fix_fetch_from_follower_offset_retry branch April 19, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seeing occasional segfaults with latest release
2 participants