-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for unexpected raw responses #774
Conversation
… in two since one of the test uses connect unary protocol and the others are protocol-agnostic
d6a7343
to
462feb4
Compare
@smaye81, I had updates this to test it against latest connect-go (on main, not from a release). I've left the content-type test commented out, since it won't pass for real until we cut a connect-go release and then update this repo. But everything else is good. The only changes I made were to reconcile this with the recent changes to the location and naming conventions of test suite files. I also split the one new file into two since the last test case is using the Connect unary protocol in the response, so it seemed like it belongs in a Connect-specific file. (The other test cases work with all protocols.) Anyhow, I think we should go ahead and move this out of draft and merge it. The commented out test has a TODO, and we can address it in a later PR (hopefully tomorrow afternoon). |
Sounds good. Thanks for updating! |
This adds tests for unexpected values such as: