Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for unexpected raw responses #774

Merged
merged 15 commits into from
Feb 15, 2024
Merged

Conversation

smaye81
Copy link
Member

@smaye81 smaye81 commented Feb 7, 2024

This adds tests for unexpected values such as:

  • Unmapped HTTP code
  • Nonexistent HTTP code
  • Invalid Content-Type
  • Invalid Content-Encoding

@jhump
Copy link
Member

jhump commented Feb 15, 2024

@smaye81, I had updates this to test it against latest connect-go (on main, not from a release). I've left the content-type test commented out, since it won't pass for real until we cut a connect-go release and then update this repo. But everything else is good. The only changes I made were to reconcile this with the recent changes to the location and naming conventions of test suite files. I also split the one new file into two since the last test case is using the Connect unary protocol in the response, so it seemed like it belongs in a Connect-specific file. (The other test cases work with all protocols.)

Anyhow, I think we should go ahead and move this out of draft and merge it. The commented out test has a TODO, and we can address it in a later PR (hopefully tomorrow afternoon).

@smaye81 smaye81 marked this pull request as ready for review February 15, 2024 02:00
@smaye81
Copy link
Member Author

smaye81 commented Feb 15, 2024

Sounds good. Thanks for updating!

@smaye81 smaye81 merged commit 926b534 into main Feb 15, 2024
7 checks passed
@smaye81 smaye81 deleted the sayers/unexpected_tests branch February 15, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants