Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call cleanup in the finally of each method response instead of abort #1118

Closed
wants to merge 1 commit into from

Conversation

lourd
Copy link

@lourd lourd commented Jun 26, 2024

Fixes #1117, avoids user code from having to check the given abort signal to determine if an abort was a true abort or not, and avoids the small overhead of having to execute all abort event handlers.

@lourd
Copy link
Author

lourd commented Jun 27, 2024

@srikrsna-buf @timostamm please let me know if there's anything you need from me for reviewing this!

Signed-off-by: Louis DeScioli <louis.descioli@gmail.com>
@srikrsna-buf
Copy link
Member

Closing this, #1117 will be addressed in v2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Returning or throwing from a method always triggers an abort
2 participants