Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow JSON in the gRPC-web transport of @bufbuild/connect-web #334

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

timostamm
Copy link
Member

This adds a new feature to @bufbuild/connect-web. With the following call:

import { createGrpcWebTransport } from "@bufbuild/connect-web-next";

createGrpcWebTransport({
   baseUrl: "https://demo.connect.build",
   useBinaryFormat: false
});

Messages are sent in the JSON format. The default behavior format remains binary, because not all server implementations support the JSON format.

Comment on lines +30 to +32
"@bufbuild/connect-web (Connect, binary) against connect-go (h1)",
"@bufbuild/connect-web (Connect, binary) against connect-go (h2)",
"@bufbuild/connect-web (Connect, binary) against @bufbuild/connect-node (h1)",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The list of transports to test is growing. Renamed the keys for better readability.

@timostamm timostamm merged commit eaa27f3 into main Nov 22, 2022
@timostamm timostamm deleted the tstamm/connect-web+grpc-web+json branch November 22, 2022 15:37
@smaye81 smaye81 mentioned this pull request Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants