Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove error from polyfill #510

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Remove error from polyfill #510

merged 1 commit into from
Mar 6, 2023

Conversation

smaye81
Copy link
Member

@smaye81 smaye81 commented Mar 3, 2023 •
edited
Loading

Fixes #509.

Previously the Node Headers polyfill was throwing an error if the Node version was < 18 and Headers was defined. However, this doesn't account for users of the library who have already polyfilled Headers.

This removes the error from being thrown and just returns the global Headers if defined.

@smaye81 smaye81 requested a review from timostamm March 3, 2023 15:10
@smaye81 smaye81 merged commit 07a35c3 into main Mar 6, 2023
@smaye81 smaye81 deleted the sayers/remove_polyfill_error branch March 6, 2023 15:13
@smaye81 smaye81 mentioned this pull request Mar 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timostamm timostamm timostamm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Headers polyfill should print a warning instead of throwing.
2 participants
@smaye81 @timostamm