Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move transport implementations to the @bufbuild/connect package #546

Merged
merged 3 commits into from
Mar 24, 2023

Conversation

timostamm
Copy link
Member

This PR moves the actual logic of the gRPC, gRPC-web, and Connect transports to subpaths in @bufbuild/connect.

For example, @bufbuild/connect/protocol-connect exports createTransport now - a function that takes the common transport options, but also a httpClient: UniversalClientFn. Moving it there makes sense for consistency (the server-part createHandlerFactory sits right next to it). But this move will also be helpful to slim down our public API, and to support other platforms.

This also enables the isolatedModules tsconfig option for our packages (we've been using the example project as a canary so far, but it didn't give us good coverage).

@timostamm timostamm requested a review from smaye81 March 24, 2023 10:24
@timostamm timostamm merged commit 27bcb7b into main Mar 24, 2023
@timostamm timostamm deleted the tstamm/move-transports branch March 24, 2023 13:42
@smaye81 smaye81 mentioned this pull request Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants