Upgrade to TypeScript 5.0 #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades Connect-ES' packages to use TypeScript 5.0.3.
The major change was to accommodate the new
verbatimModuleSyntaxflag. This required removing the usage ofimportsNotUsedAsValuesfrom our main tsconfig and applying the new flag to any build commands generating ESM output. Note that we can't use this in our maintsconfig.base.jsonbecause it isn't permitted when the module output is CJS.For consistency, this flag was used in all the CLI commands for generating ESM. The only place where it was put into the actual
tsconfig.jsonwas for theexample.