Ignore unknown JSON fields in Connect unary responses #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timostamm
reviewed
Jun 13, 2023
Comment on lines
208
to
210
| if (options.jsonOptions) { | ||
| options.jsonOptions.ignoreUnknownFields ??= true; | ||
| } |
There was a problem hiding this comment.
This code block does not run if no jsonOptions are given, and unknown fields will not be ignored.
|
We should avoid duplicating the logic to change the settings. Let's add a function instead: export function getJsonOptions(options: Partial<JsonReadOptions & JsonWriteOptions> | undefined) {
const o = {...options};
o.ignoreUnknownFields ??= true;
return o;
}And use that in serialization.ts, and in connect-transport.ts. |
timostamm
approved these changes
Jun 14, 2023
timostamm
changed the title
Co-authored-by: Timo Stamm <ts@timostamm.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ignores unknown fields by default if the format is JSON when parsing a response. This was put into place in #642, but this is actually a special case that doesn't follow the code path in #642 and must be handled separately.