Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update otel libraries to v1.20.0 #146

Closed
wants to merge 2 commits into from
Closed

Update otel libraries to v1.20.0 #146

wants to merge 2 commits into from

Conversation

emcfarlane
Copy link
Collaborator

@emcfarlane emcfarlane commented Nov 13, 2023

Dependency updates. Update for otel v1.20.0, connect v1.12.0 and go-cmp 0.6.

@emcfarlane emcfarlane self-assigned this Nov 13, 2023
@pkwarren
Copy link
Contributor

Looks like we'll need to bump to Go 1.20 to pick up the latest version:

Error: ../../../go/pkg/mod/go.opentelemetry.io/otel/sdk/metric@v1.20.0/meter.go:472:26: undefined: errors.Join
Error: ../../../go/pkg/mod/go.opentelemetry.io/otel/sdk/metric@v1.20.0/meter.go:516:26: undefined: errors.Join
note: module requires Go 1.20

@emcfarlane
Copy link
Collaborator Author

emcfarlane commented Nov 13, 2023

Reverted the changes so now updated only for connect and go-cmp. No changes needed for v1.20 so safe to close or merge the connect update.

@akshayjshah
Copy link
Member

Do we need any of these changes? I don't like habitually bumping dependencies in libraries, because it forces end-users to upgrade. If we need a feature from the new Connect or cmp releases, that's fine. Otherwise, why not leave end users more freedom?

@emcfarlane
Copy link
Collaborator Author

@akshayjshah yes totally not. I saw libraries required changes so was concerned if we needed any updates. All good though, closing!

@emcfarlane emcfarlane closed this Nov 13, 2023
@emcfarlane emcfarlane deleted the ed/update-otel branch November 13, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants