Upgrade opentelemetry go #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgmitche
approved these changes
Mar 2, 2023
There was a problem hiding this comment.
LGTM, had to check why the unit's changed, but its here:
open-telemetry/opentelemetry-go@fe6856e
This is - predictably - a tragically awful API. |
akshayjshah
reviewed
Mar 2, 2023
| @@ -35,6 +34,9 @@ const ( | |||
| clientKey = "client" | |||
| requestKey = "request" | |||
| responseKey = "response" | |||
| dimensionless = "1" | |||
| bytes = "By" | |||
| milliseconds = "ms" | |||
There was a problem hiding this comment.
Post-hoc suggestion: these are pretty common names for this sort of code, which makes it likely that we'll mistakenly shadow them in a future change. Could we change to unitDimensionless, unitBytes, and unitMilliseconds instead?
akshayjshah
pushed a commit
that referenced
this pull request
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades + code changes that are needed