Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Chinese Translation #8

Merged
merged 4 commits into from
Aug 24, 2020
Merged

Add Chinese Translation #8

merged 4 commits into from
Aug 24, 2020

Conversation

yining1023
Copy link
Collaborator

@yining1023 yining1023 commented Aug 24, 2020 •
edited
Loading

This PR -

  • Adds chinse translation in zh_Hans/translation.json
  • Fixes some links where /gallery2020 should be /gallery2020-All or it could use the relative link /gallery2019
  • Moves the Acknowledgements section content into the translation
  • Uses English filter names in the URL in GalleryTwenty.js instead of using the translated filter names like /gallery2020-全部
  • Scroll back to top when going back to 2019 and 2020 gallery

Screen Shot 2020-08-23 at 9 09 38 PM

Screen Shot 2020-08-23 at 9 09 56 PM

Screen Shot 2020-08-23 at 9 10 04 PM

@yining1023 yining1023 mentioned this pull request Aug 24, 2020
Open
@connieliu0
Copy link
Owner

Thank you so much for the review yining!

@connieliu0 connieliu0 merged commit 68b25cd into master Aug 24, 2020
@connieliu0 connieliu0 deleted the tranlate branch September 5, 2020 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connieliu0 connieliu0 Awaiting requested review from connieliu0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yining1023 @connieliu0