Fix start script path so photon builds! 馃檶馃徎 #11

Merged
merged 2 commits into from Oct 13, 2015

Projects

None yet

2 participants

@ggamel
Contributor
ggamel commented Oct 13, 2015

This resolves the issue in #9.

See image of app after fix: photon-fixed

@ggamel ggamel referenced this pull request Oct 13, 2015
Closed

Error building #9

@connors connors commented on an outdated diff Oct 13, 2015
@@ -18,7 +18,7 @@
"url": "https://github.com/connors/photon/issues"
},
"scripts": {
- "start": "electron example-components"
+ "start": "electron dist/template-app/app.js"
@connors
connors Oct 13, 2015 Owner

I think this can just be electron dist/template-app

@connors
Owner
connors commented Oct 13, 2015

Whoops! Good catch. I just left one comment but otherwise that looks good.

@ggamel
Contributor
ggamel commented Oct 13, 2015

@connors Just updated the PR, again. Works 100% on my end.

@connors
Owner
connors commented Oct 13, 2015

Helllll yeah

@connors connors merged commit ada22d1 into connors:master Oct 13, 2015
@connors connors modified the milestone: v0.1.1 Oct 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment