Added Default User Shell when executing Commands #131
+39
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was playing around with this extension, and for the most part, it works great. However, I ran into one issue: it did not use my default shell defined within the command line. This is a problem as I have some environment variables and path info that are not generally accessible to my other bash shells. This resulted in many please set
RAILS_MASTER_KEY
errors, which are easy to fix. However, it would not be nice to use my default shell when it detected it or others' default shells as this could save a lot of pain with differences in pathing info.This concept was pulled from Ruby LSP so can't take credit for the code.
Above is the output it generates when I change the default shell to fishshell. This also works for zsh and bash.
Some screenshots showing it working for rspec.