This repository has been archived by the owner on Jan 11, 2024. It is now read-only.
FM-18: Check transactions #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes consensus-shipyard/ipc#285
Implements a new
CheckInterpreterstack that performs nonce and balance checks on incoming transactions before they are added to the mempool. The successful results update a temporary state represented by theStateTreeon top of the latest state root hash, so the next transaction sent by the same account is checked against the tentative state.NOTE: The current state does not check that the message sets any reasonable
gas_fee_cap. I'm not fully comfortable with the gas rules of theref-fvmcalculated in GasOutputs, however it definitely allows the fee to be set to zero, in which case as far as I can see the miner pays. It would make sense to include a rule in theFvmMessageInterpreterwhich rejects transactions if they don't set a reasonable fee, perhaps based on thebase_fee. I'll create a story for this and have a look at what Forest is doing.