-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/ssv deposit balance #160
Conversation
@ccali11 the last two commits add ethers.Signer implementations for Ledger and WalletConnect in the common directory. Can you pull the latest down and test the WalletConnect message signer method in your UI (I don't have WalletConnect set up)? Let's meet on this since I probably need to explain myself (went a bit overboard, but this should standardize things well moving forward). |
Approved and suitable to merge once we confirm all ethers wallets are working as expected for check balance, deposit, and sign message. |
@shanejearley - Please see PR for #24. Worth reviewing a bit together to discuss a few findings as well as unresolved notes that I have. Here is a checklist we can review:
Error: Transaction reverted: function selector was not recognized and there's no fallback function
await ssv.connect(provider).getUserBalanceForPool(userAddress, pool)
(including current for loop implementation in front-end component)services/auth/
Looking forward to catching up!