-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polish CI #254
Polish CI #254
Conversation
The actions-rs organization is unmaintained with the sole member being unresponsive for two years. The actions still use Node 12 and the `set-output` command, both of which are deprecated and will be removed by Github Actions by Summer 2023. [1][2] Switch from `actions-rs/toolchain` to `dtolnay/rust-toolchain` and from `actions-rs/cargo` to plain cargo commands. [1] https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/ [2] https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
From the documentation of `--all-targets`: Check all targets. This is equivalent to specifying --lib --bins --tests --benches --examples.
Newer versions may have additional lints which would be missed by running MSRV Clippy.
Can you give me an example on where the actions are falling apart? One advantage of cargo action is that it comments the warnings and errors on GitHub. |
Quoting from the relevant commit message:
|
I think this needs rebase. |
Rebased. Am I assuming correctly that the other two comments you left about the examples and the tag have resolved themselves? Can't find them in the web UI and you approved the PR, so it looks like you deleted them. |
See the individual commits for details.