-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix addition overflow in AtomicPosition
#406
Conversation
786ae0c
to
ed9add5
Compare
ed9add5
to
5c88a48
Compare
The `Default` implementation was confusing to me. I would expect that `AtomicPosition::default() == AtomicPosition::default()` in all cases.
5c88a48
to
4f198fb
Compare
Sorry for the delay. Resolved by doing arithmetic in FWIW, I would advise avoiding the use of |
That discussion is pretty old at this point, though. Here's a more recent one: https://internals.rust-lang.org/t/lets-deprecate-as-for-lossy-numeric-casts/16283/45 Note that this talks about deprecating |
@djc Thanks for merging. Please let me know when there's another release/pre-release so that I can publish a version of my package which depends on |
I've published rc10. |
Closes #405.