Handle newline in msg and empty msg #540
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
println()
with a new line at the beginning of the message trigger some artifacts, see below:newline_artifact.rs
Output on
![image](https://private-user-images.githubusercontent.com/64585623/237698604-f8357aa0-de1f-4e29-b431-df44aa3a431e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA1NDYxOTAsIm5iZiI6MTcyMDU0NTg5MCwicGF0aCI6Ii82NDU4NTYyMy8yMzc2OTg2MDQtZjgzNTdhYTAtZGUxZi00ZTI5LWI0MzEtZGY0NGFhM2E0MzFlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzA5VDE3MjQ1MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWJhOTZlZDU4MzAzZmU1YWZjNThkMGQzOTJkY2JlY2MxNmJiZGY2MWUxZTM3MGUwYzI2NzRjZmI2NGYwNDMxNjQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.ihUDrG_ZWJaf9tXudahtCk8v_04YTZ5XE5EhFX-O-4s)
![image](https://private-user-images.githubusercontent.com/64585623/237698763-f77644dd-983d-4540-b6a4-94ba7b77b88d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA1NDYxOTAsIm5iZiI6MTcyMDU0NTg5MCwicGF0aCI6Ii82NDU4NTYyMy8yMzc2OTg3NjMtZjc3NjQ0ZGQtOTgzZC00NTQwLWI2YTQtOTRiYTdiNzdiODhkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzA5VDE3MjQ1MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWRkZGQzYmVmNDZkYmZmODk3ZmQ5NGE5ZjlmOTUxZTQxZDU2M2I4N2M5NzUzZWJmNWVmZWFkZTE2YzJkZWFlOTImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.ojQ6CfpOIb1JFKy5wmwfBwiT24GKSrTCdl69VdDkAgo)
main
:Output with this patch:
Using
println()
with an empty string does not trigger new line:empty_msg.rs
Output on
![image](https://private-user-images.githubusercontent.com/64585623/237699428-5dc11f7e-4961-43d9-8026-cc3da5768da0.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA1NDYxOTAsIm5iZiI6MTcyMDU0NTg5MCwicGF0aCI6Ii82NDU4NTYyMy8yMzc2OTk0MjgtNWRjMTFmN2UtNDk2MS00M2Q5LTgwMjYtY2MzZGE1NzY4ZGEwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzA5VDE3MjQ1MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTM3ZDJjMTRiODI1NWRkNmEwZjhhNDBjYWUzMzhiOTRkNDg5ZjNiMDhkMzg1NzUxMjlhOTYzZmUxNWZiMmI4NjImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.jDGw-lHdBXTu2W5ejNNtLC2uX2N_1jLxhFOYDNvFoFU)
main
:Output with this patch:
![image](https://private-user-images.githubusercontent.com/64585623/237699368-d9e0e571-27ac-4330-8438-6b491ed7f9fd.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA1NDYxOTAsIm5iZiI6MTcyMDU0NTg5MCwicGF0aCI6Ii82NDU4NTYyMy8yMzc2OTkzNjgtZDllMGU1NzEtMjdhYy00MzMwLTg0MzgtNmI0OTFlZDdmOWZkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzA5VDE3MjQ1MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTYzMmY4NjM2YWMxMDc0ZGViMDNhZTlmOGNkNzE0M2Y0MWNlZWI2MmViYzUyMjU0ZmE3MjNhNWQ5ZThjNTYyMjAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.EPKCuVJkhXnj9ucRqPZE0i-_7rpCOtRdHIp2b5jY7Os)
New test in
render.rs
showcase both issue