Should we escape exclude patterns in RsyncTask?

[boedah]

If you want to exclude patterns with a wildcard, e.g. *.scss, it will not exclude these files but (as the shell expands the wildcard) also sync matching files in the current working directory (which is certainly not what you want ;).

In exclude() method of rsync task (https://github.com/Codegyre/Robo/blob/master/src/Task/Rsync.php#L241), we could add escapeshellarg:

return $this->option('exclude', escapeshellarg($pattern));

This would be a BC break for people who already added ' themselves:

$rsync->exclude("'*.scss'");

But from my point of view, it should be escaped.

[DavertMik]

Breaking BC before the stable version releases is not so painful.
This is a good time to came to agreement on defaults and interfaces.
Sure escapeshellarg should be added there....

P.S. never heard of that function before :|

[boedah]

Ok, will create a PR the next days.

escapeshellarg should be used everywhere a user-supplied value is used as shell argument because there can be spaces, quotes, wildcards... in it.
I have not looked in the other Robo tasks if it should be applied also.