Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add event registration #68

Closed

Conversation

bomoko
Copy link

@bomoko bomoko commented Sep 5, 2023

Overview

This pull request: Adds event dispatching for site aliases that are not found through the usual resolution methods

Q A
Bug fix? no
New feature? yes
Has tests? yes
BC breaks? no
Deprecations? no

Summary

Implemented the Symfony EventDispatcher component and introduced a new event

closes #66

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #68 (1ba49cb) into main (b0eeb8c) will increase coverage by 1.02%.
The diff coverage is 100.00%.

❗ Current head 1ba49cb differs from pull request most recent head f8f8b30. Consider uploading reports for the commit f8f8b30 to get more accurate results

@@             Coverage Diff              @@
##               main      #68      +/-   ##
============================================
+ Coverage     59.15%   60.17%   +1.02%     
- Complexity      283      290       +7     
============================================
  Files            12       13       +1     
  Lines           661      678      +17     
============================================
+ Hits            391      408      +17     
  Misses          270      270              
Files Changed Coverage Δ
src/Events/AliasNotFoundEvent.php 100.00% <100.00%> (ø)
src/SiteAliasManager.php 62.31% <100.00%> (+5.65%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bomoko bomoko closed this Sep 5, 2023
@bomoko bomoko deleted the feature/add-event-registration branch September 5, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to add custom fallback site alias resolvers
1 participant