Skip to content

CH 9626 : Preferences Helper Tests #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 13, 2020
Merged

CH 9626 : Preferences Helper Tests #41

merged 2 commits into from
May 13, 2020

Conversation

rubikzube
Copy link
Contributor

@rubikzube rubikzube commented May 13, 2020 •
edited
Loading

  • Renamed TokenInterceptor to RequestInterceptor
  • Renamed Token to apiKey for consistency
  • Added more and better preference helper tests
  • Removed the DataManagerTests

@rubikzube rubikzube requested a review from crgee1 May 13, 2020 03:51
crgee1
crgee1 reviewed May 13, 2020
View reviewed changes
library/src/test/java/io/constructor/data/local/PreferencesHelperTest.kt
@@ -13,54 +12,78 @@ import java.util.concurrent.TimeUnit
@RunWith(RobolectricTestRunner::class)
class PreferencesHelperTest {

private var preferencesHelper = spyk(PreferencesHelper(RuntimeEnvironment.application.applicationContext, "test.prefs"))
private val partyLikeIts1999 = 946684800000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rad

crgee1
crgee1 approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@crgee1 crgee1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rubikzube rubikzube merged commit fe9ec41 into master May 13, 2020
@rubikzube rubikzube deleted the ch9626/test-updates-2 branch May 25, 2020 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crgee1 crgee1 crgee1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rubikzube @crgee1