Bump rubocop-performance from 1.7.1 to 1.10.1 #4384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot-preview[bot]](https://avatars.githubusercontent.com/in/2141?s=60&v=4){kind=small}
dependabot-preview
bot
added
the
dependencies
dependabot-preview
bot
force-pushed
the
dependabot/bundler/rubocop-performance-1.10.1
branch
2 times, most recently
from
e55bd04
to
e114ed7
Compare
|
This pull request will no longer be automatically closed when a new version is found as this pull request was created by Dependabot Preview and this repo is using a |
javierm
force-pushed
the
dependabot/bundler/rubocop-performance-1.10.1
branch
from
e114ed7
to
cef7811
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
javierm
force-pushed
the
dependabot/bundler/rubocop-performance-1.10.1
branch
from
cef7811
to
db4451c
Compare
Bumps [rubocop-performance](https://github.com/rubocop/rubocop-performance) from 1.7.1 to 1.10.1. - [Release notes](https://github.com/rubocop/rubocop-performance/releases) - [Changelog](https://github.com/rubocop/rubocop-performance/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop-performance@v1.7.1...v1.10.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
We're not adding it for performance reasons but because it simplifies the code.
javierm
approved these changes
Aug 10, 2021
We don't need to use `block_given?` since we specifically pass the block parameter, particularly since we added the Style/ExplicitBlockArgument rule in commit a102f3f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps rubocop-performance from 1.7.1 to 1.10.1.
Release notes
Sourced from rubocop-performance's releases.
... (truncated)
Changelog
Sourced from rubocop-performance's changelog.
... (truncated)
Commits
9e407f1Cut 1.10.1331ecbeFix antora.yml to be updated when runningcut_releasetask0e07cd9Merge pull request #218 from koic/fix_a_false_positive_for_redundant_equality...79763fe[Fix #217] Fix a false positive for `Performance/RedundantEqualityComparisonB...ac6f67bMerge pull request #219 from koic/fix_false_positive_for_performance_redundan...12339c5[Fix #216] Fix a false positive forPerformance/RedundantSplitRegexpArgumentf35ffd0Fix an incorrect issue number in the changelogb7f9798Merge pull request #215 from koic/fix_false_positive_for_redundant_equality_c...8cef567[Fix #214] Fix a false positive for `Performance/RedundantEqualityComparisonB...c8bea56Switch back docs version to masterDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labelswill set the current labels as the default for future PRs for this repo and language@dependabot use these reviewerswill set the current reviewers as the default for future PRs for this repo and language@dependabot use these assigneeswill set the current assignees as the default for future PRs for this repo and language@dependabot use this milestonewill set the current milestone as the default for future PRs for this repo and language@dependabot badge mewill comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in your Dependabot dashboard: