Remove official level filter from advanced search #4668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| visit debates_path | ||
| create(:budget_investment, heading: heading, title: "Get Schwifty", sdg_goals: [SDG::Goal[7]], created_at: 1.minute.ago) |
There was a problem hiding this comment.
Layout/LineLength: Line is too long. [126/110] (https://rubystyle.guide#max-line-length)
|
|
||
| visit debates_path | ||
| create(:budget_investment, heading: heading, title: "Get Schwifty", sdg_goals: [SDG::Goal[7]], created_at: 1.minute.ago) | ||
| create(:budget_investment, heading: heading, title: "Hello Schwifty", sdg_goals: [SDG::Goal[7]], created_at: 2.days.ago) |
There was a problem hiding this comment.
Layout/LineLength: Line is too long. [126/110] (https://rubystyle.guide#max-line-length)
| end | ||
| within ".advanced-search-form" do | ||
| expect(page).to have_select("advanced_search[date_min]", selected: "Customized") | ||
| expect(page).to have_selector("input[name='advanced_search[date_min]'][value*='#{7.days.ago.strftime("%d/%m/%Y")}']") |
There was a problem hiding this comment.
Layout/LineLength: Line is too long. [125/110] (https://rubystyle.guide#max-line-length)
| within ".advanced-search-form" do | ||
| expect(page).to have_select("advanced_search[date_min]", selected: "Customized") | ||
| expect(page).to have_selector("input[name='advanced_search[date_min]'][value*='#{7.days.ago.strftime("%d/%m/%Y")}']") | ||
| expect(page).to have_selector("input[name='advanced_search[date_max]'][value*='#{1.day.ago.strftime("%d/%m/%Y")}']") |
There was a problem hiding this comment.
Layout/LineLength: Line is too long. [124/110] (https://rubystyle.guide#max-line-length)
javierm
force-pushed
the
official_level_search
branch
from
223dd77
to
4e5b878
Compare
javierm
force-pushed
the
official_level_search
branch
from
4e5b878
to
209981a
Compare
javierm
force-pushed
the
official_level_search
branch
from
209981a
to
3347157
Compare
User testing has shown this filter isn't really useful and sometimes makes users wonder what it's about. This is particularly true in CONSUL installations which don't change the default values (most of them), since users will see a filter with options like "Official position 1".
When users see a label saying "With the text" and an input field, they don't usually need a placeholder saying "Write the text". On the contrary, this text adds noise and is hard to read due to the low contrast between the color of the placeholder and the color of the field, making the text an unnecessary distraction.
taitus
approved these changes
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objectives
Notes
User testing has shown this filter isn't really useful and sometimes makes users wonder what it's about. This is particularly true in CONSUL installations which don't change the default values (most of them), since users will see a filter with options like "Official position 1".
Visual changes
Before these changes
After these changes