Enable SDG content by default #4673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
force-pushed
the
enable_sdg_by_default
branch
from
2d038da
to
26c56d7
Compare
javierm
force-pushed
the
enable_sdg_by_default
branch
from
26c56d7
to
85a9e8b
Compare
javierm
force-pushed
the
enable_sdg_by_default
branch
from
85a9e8b
to
6e3e8f1
Compare
We didn't enable it by default in commit 676adfc so existing installations didn't suddenly get a new section without expecting it. But since the setting already exists for installations using version CONSUL 1.3, now it will only be enabled for new installations.
javierm
force-pushed
the
enable_sdg_by_default
branch
from
6e3e8f1
to
797f61c
Compare
taitus
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives
Notes
We didn't enable SDG by default in pull request #4251 so existing installations didn't suddenly get a new section without expecting it.
But since the setting already exists for installations using version CONSUL 1.3, now it will only be enabled for new installations.