Merge pull request #4472 from consul/visit_after_setup

Setup database before starting the browser in tests

spec/system/admin/administrators_spec.rb

@@ -5,12 +5,11 @@
   let!(:user) { create(:user, username: "Jose Luis Balbin") }
   let!(:user_administrator) { create(:administrator, description: "admin_alias") }
 
-  before do
-    login_as(admin.user)
-    visit admin_administrators_path
-  end
+  before { login_as(admin.user) }
 
   scenario "Index" do
+    visit admin_administrators_path
+
     expect(page).to have_content user_administrator.id
     expect(page).to have_content user_administrator.name
     expect(page).to have_content user_administrator.email
@@ -19,6 +18,8 @@
   end
 
   scenario "Create Administrator" do
+    visit admin_administrators_path
+
     fill_in "search", with: user.email
     click_button "Search"
 
@@ -30,6 +31,8 @@
   end
 
   scenario "Delete Administrator" do
+    visit admin_administrators_path
+
     within "#administrator_#{user_administrator.id}" do
       accept_confirm { click_link "Delete" }
     end
@@ -40,6 +43,8 @@
   end
 
   scenario "Delete Administrator when its the current user" do
+    visit admin_administrators_path
+
     within "#administrator_#{admin.id}" do
       accept_confirm { click_link "Delete" }
     end

spec/system/admin/managers_spec.rb

@@ -4,17 +4,17 @@
   let!(:user) { create(:user) }
   let!(:manager) { create(:manager) }
 
-  before do
+  scenario "Index" do
     visit admin_managers_path
-  end
 
-  scenario "Index" do
     expect(page).to have_content manager.name
     expect(page).to have_content manager.email
     expect(page).not_to have_content user.name
   end
 
   scenario "Create Manager" do
+    visit admin_managers_path
+
     fill_in "search", with: user.email
     click_button "Search"
 
@@ -26,6 +26,8 @@
   end
 
   scenario "Delete Manager" do
+    visit admin_managers_path
+
     accept_confirm { click_link "Delete" }
 
     within("#managers") do

spec/system/admin/moderators_spec.rb

@@ -4,17 +4,17 @@
   let!(:user)      { create(:user, username: "Jose Luis Balbin") }
   let!(:moderator) { create(:moderator) }
 
-  before do
+  scenario "Index" do
     visit admin_moderators_path
-  end
 
-  scenario "Index" do
     expect(page).to have_content moderator.name
     expect(page).to have_content moderator.email
     expect(page).not_to have_content user.name
   end
 
   scenario "Create Moderator" do
+    visit admin_moderators_path
+
     fill_in "search", with: user.email
     click_button "Search"
 
@@ -26,6 +26,8 @@
   end
 
   scenario "Delete Moderator" do
+    visit admin_moderators_path
+
     accept_confirm { click_link "Delete" }
 
     within("#moderators") do

spec/system/admin/sdg/managers_spec.rb

@@ -4,18 +4,19 @@
   let!(:user) { create(:user) }
   let!(:sdg_manager) { create(:sdg_manager) }
 
-  before do
-    login_as(create(:administrator).user)
-    visit admin_sdg_managers_path
-  end
+  before { login_as(create(:administrator).user) }
 
   scenario "Index" do
+    visit admin_sdg_managers_path
+
     expect(page).to have_content sdg_manager.name
     expect(page).to have_content sdg_manager.email
     expect(page).not_to have_content user.name
   end
 
   scenario "Create SDG Manager" do
+    visit admin_sdg_managers_path
+
     fill_in "search", with: user.email
     click_button "Search"
 
@@ -29,6 +30,8 @@
   end
 
   scenario "Delete SDG Manager" do
+    visit admin_sdg_managers_path
+
     accept_confirm { click_link "Delete" }
 
     within("#sdg_managers") do

spec/system/admin/site_customization/pages_spec.rb

@@ -14,13 +14,13 @@
       slugs = %w[accessibility conditions faq privacy welcome_not_verified
                  welcome_level_two_verified welcome_level_three_verified]
 
-      visit admin_site_customization_pages_path
-
       expect(SiteCustomization::Page.count).to be 7
       slugs.each do |slug|
         expect(SiteCustomization::Page.find_by(slug: slug).status).to eq "published"
       end
 
+      visit admin_site_customization_pages_path
+
       expect(all("[id^='site_customization_page_']").count).to be 7
       slugs.each do |slug|
         expect(page).to have_content slug

spec/system/admin/users_spec.rb

@@ -4,19 +4,20 @@
   let(:admin) { create(:administrator) }
   let!(:user) { create(:user, username: "Jose Luis Balbin") }
 
-  before do
-    login_as(admin.user)
-    visit admin_users_path
-  end
+  before { login_as(admin.user) }
 
   scenario "Index" do
+    visit admin_users_path
+
     expect(page).to have_link user.name
     expect(page).to have_content user.email
     expect(page).to have_content admin.name
     expect(page).to have_content admin.email
   end
 
   scenario "The username links to their public profile" do
+    visit admin_users_path
+
     within_window(window_opened_by { click_link user.name }) do
       expect(page).to have_current_path(user_path(user))
     end
@@ -45,6 +46,8 @@
   end
 
   scenario "Search" do
+    visit admin_users_path
+
     fill_in :search, with: "Luis"
     click_button "Search"
 

spec/system/admin/valuators_spec.rb

@@ -4,8 +4,6 @@
   let!(:user) { create(:user, username: "Jose Luis Balbin") }
   let!(:valuator) { create(:valuator, description: "Very reliable") }
 
-  before { visit admin_valuators_path }
-
   scenario "Show" do
     visit admin_valuator_path(valuator)
 
@@ -16,12 +14,16 @@
   end
 
   scenario "Index" do
+    visit admin_valuators_path
+
     expect(page).to have_content(valuator.name)
     expect(page).to have_content(valuator.email)
     expect(page).not_to have_content(user.name)
   end
 
   scenario "Create" do
+    visit admin_valuators_path
+
     fill_in "search", with: user.email
     click_button "Search"
 
@@ -51,6 +53,8 @@
   end
 
   scenario "Destroy" do
+    visit admin_valuators_path
+
     accept_confirm { click_link "Delete" }
 
     within("#valuators") do

spec/system/budgets/ballots_spec.rb

@@ -41,10 +41,7 @@
   end
 
   context "Voting" do
-    before do
-      login_as(user)
-      visit budget_path(budget)
-    end
+    before { login_as(user) }
 
     let!(:city) { create(:budget_group, budget: budget, name: "City") }
     let!(:districts) { create(:budget_group, budget: budget, name: "Districts") }

spec/system/dashboard/dashboard_spec.rb

@@ -484,10 +484,7 @@
   end
 
   describe "detect_new_actions_after_last_login" do
-    before do
-      visit proposal_dashboard_path(proposal)
-      proposal.author.update!(last_sign_in_at: Date.yesterday)
-    end
+    before { proposal.author.update!(current_sign_in_at: 1.day.ago) }
 
     scenario "Display tag 'new' on resouce when it is new for author since last login" do
       resource = create(:dashboard_action, :resource, :active, day_offset: 0,
@@ -503,7 +500,7 @@
     scenario "Not display tag 'new' on resouce when there is not new resources since last login" do
       resource = create(:dashboard_action, :resource, :active, day_offset: 0,
                                                                published_proposal: false)
-      proposal.author.update!(last_sign_in_at: Date.current)
+      proposal.author.update!(current_sign_in_at: Date.current)
 
       visit progress_proposal_dashboard_path(proposal)
 
@@ -526,7 +523,7 @@
     scenario "Not display tag 'new' on proposed_action when there is not new since last login" do
       proposed_action = create(:dashboard_action, :proposed_action, :active, day_offset: 0,
                                                                      published_proposal: false)
-      proposal.author.update!(last_sign_in_at: Date.current)
+      proposal.author.update!(current_sign_in_at: Date.current)
 
       visit progress_proposal_dashboard_path(proposal)
 
@@ -547,7 +544,7 @@
 
     scenario "Not display tag 'new' on sidebar when there is not a new resouce since last login" do
       create(:dashboard_action, :resource, :active, day_offset: 0, published_proposal: false)
-      proposal.author.update!(last_sign_in_at: Date.current)
+      proposal.author.update!(current_sign_in_at: Date.current)
 
       visit progress_proposal_dashboard_path(proposal)
 

spec/system/dashboard/polls_spec.rb

@@ -3,16 +3,16 @@
 describe "Polls" do
   let!(:proposal) { create(:proposal, :draft) }
 
-  before do
-    login_as(proposal.author)
-    visit proposal_dashboard_path(proposal)
-  end
+  before { login_as(proposal.author) }
 
   scenario "Has a link to polls feature" do
+    visit proposal_dashboard_path(proposal)
+
     expect(page).to have_link("Polls")
   end
 
   scenario "Create a poll" do
+    visit proposal_dashboard_path(proposal)
     click_link "Polls"
     click_link "Create poll"
 
@@ -80,6 +80,7 @@
   end
 
   scenario "Create a poll redirects back to form when invalid data" do
+    visit proposal_dashboard_path(proposal)
     click_link "Polls"
     click_link "Create poll"
 

spec/system/officing/residence_spec.rb

@@ -114,14 +114,15 @@
   context "With remote census configuration", :remote_census do
     before do
       create(:poll_officer_assignment, officer: officer)
-      login_through_form_as_officer(officer.user)
-      visit officing_root_path
     end
 
     describe "Display form fields according to the remote census configuration" do
       scenario "by default (without custom census) not display date_of_birth and postal_code" do
         Setting["feature.remote_census"] = false
 
+        login_through_form_as_officer(officer.user)
+        visit officing_root_path
+
         within("#side_menu") do
           click_link "Validate document"
         end
@@ -134,6 +135,9 @@
       end
 
       scenario "with all custom census not display year_of_birth" do
+        login_through_form_as_officer(officer.user)
+        visit officing_root_path
+
         within("#side_menu") do
           click_link "Validate document"
         end
@@ -149,6 +153,9 @@
     scenario "can verify voter with date_of_birth and postal_code fields" do
       mock_valid_remote_census_response
 
+      login_through_form_as_officer(officer.user)
+      visit officing_root_path
+
       within("#side_menu") do
         click_link "Validate document"
       end

spec/system/proposals_spec.rb

@@ -200,8 +200,6 @@
       proposal = create(:proposal)
       visit proposal_path(proposal)
       expect(page).to have_content "Access the community"
-
-      Setting["feature.community"] = false
     end
 
     scenario "Can not access the community" do
@@ -746,7 +744,6 @@
     expect(page).not_to have_current_path(edit_proposal_path(proposal))
     expect(page).to have_current_path(root_path)
     expect(page).to have_content "You do not have permission"
-    Setting["max_votes_for_proposal_edit"] = 1000
   end
 
   scenario "Update should be posible for the author of an editable proposal" do