Setup database before starting the browser in tests #4472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We forgot to remove these lines in commit da121eb.
Just like we did in commit 0ec8878, we remove the useless initial request in the `before` filter since most tests started by visiting a different URL. We also reduce the risk of database inconsistency which comes with setting up the database after the browser has been started.
We were adding a `visit` in a `before` block but then we started the search tests with another `visit`. We also created records in the database in between, which increased the risk of database inconsistency since the process running the browser had already been started.
Changing the database after the process running the browser has started is proving to be one of the reasons tests are failing sometimes, so we're reducing the number of times were that happens. In this case, we were changing a setting.
We were updating the database after starting the browser to emulate the behavior where a user logs in a day before the current request. We can use `current_sign_in_at` instead and devise will automatically copy that value to `last_sign_in_at` after users visit a page. This way we avoid setting up the database after the process runnin the browser has been started.
We were adding a `visit` in a `before` block but then we started some tests with another `visit`. We also destroyed records in the database in between, which increased the risk of database inconsistency since the process running the browser had already been started. Besides, some tests were wrong; they were visiting a page with the browser, then destroying records in the database, and then checking the page without reloading the browser. Since we aren't automatically refreshing the affected areas of the page, obviously the page content before and after destroying records is exactly the same, and the test was passing because it's testing content that isn't there in any situation.
javierm
force-pushed
the
visit_after_setup
branch
from
941bd26
to
16fdffd
Compare
taitus
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives