-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve budget header #4501
Improve budget header #4501
Conversation
943cb0c
to
10d18f8
Compare
10d18f8
to
2f77b22
Compare
2f77b22
to
4388ebc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @taitus,
I found that the main_link_text
field is not translatable.
Once I made it translatable, I cannot render it at the desired position because it's not possible to render budget translation fields within different form translation_fields
blocks. Now, all the fields for a translation have to be rendered within the same translatable_fields
form block.
I tried to solve the problem to allow to use of multiple translations_fields
form blocks for the same translation, and surprisingly it works but is still experimental, furthermore, there are more design problems derived from this. So, I think the faster option is to move the main_link_text
to the current translation_fields
form block. See screenshot below:
As you can see I had to move the voting style
and currency
fields below main_link
fields.
I uploaded a copy of this branch here with a commit with possible fixes.
Here is the experimental PR to allow to have multiple translations_fields blocks for the same object.
4388ebc
to
9fed136
Compare
9fed136
to
cbe903c
Compare
As they are much faster.
As the are much faster. Keep a system spec to check the component is called from the view.
This description of the current phase is already being displayed on the same page in the section "Participatory budgets phases"
cbe903c
to
38a6338
Compare
- Allow to define a link (text and url) on budget form for render on the budget header. - Improve styles Co-authored-by: Senén Rodero Rodríguez <senenrodero@gmail.com>
38a6338
to
d78f2e0
Compare
References
Objectives
Visual Changes
Frontend
![Captura de pantalla 2021-05-06 a las 12 28 41](https://user-images.githubusercontent.com/16189/117284211-e3ff7900-ae66-11eb-8ea0-cb7c1eb1ac1c.png)
Backend
![Captura de pantalla 2021-05-06 a las 13 13 37](https://user-images.githubusercontent.com/16189/117289471-e95fc200-ae6c-11eb-8c9f-8aed1f476cab.png)