Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve budget header #4501

Merged
merged 5 commits into from
Jun 9, 2021
Merged

Improve budget header #4501

merged 5 commits into from
Jun 9, 2021

Conversation

taitus
Copy link
Member

@taitus taitus commented May 6, 2021

References

Objectives

  • Add title in the budget header
  • Not showing the phase description in the budget header
  • Allow to define a link (text and url) on budget form for render on the budget header

Visual Changes

  • Frontend
    Captura de pantalla 2021-05-06 a las 12 28 41

  • Backend
    Captura de pantalla 2021-05-06 a las 13 13 37

@taitus taitus self-assigned this May 6, 2021
@taitus taitus added the Budgets label May 6, 2021
@taitus taitus added this to Reviewing in Consul Democracy via automation May 6, 2021
@taitus taitus moved this from Reviewing to Doing in Consul Democracy May 6, 2021
@taitus taitus moved this from Doing to Reviewing in Consul Democracy May 6, 2021
@taitus taitus requested a review from Senen May 6, 2021 11:14
@taitus taitus moved this from Reviewing to Doing in Consul Democracy May 6, 2021
@taitus taitus removed the request for review from Senen May 6, 2021 11:44
@taitus taitus moved this from Doing to Reviewing in Consul Democracy May 6, 2021
@taitus taitus requested a review from Senen May 6, 2021 11:48
Copy link
Member

@Senen Senen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @taitus,

I found that the main_link_text field is not translatable.

Once I made it translatable, I cannot render it at the desired position because it's not possible to render budget translation fields within different form translation_fields blocks. Now, all the fields for a translation have to be rendered within the same translatable_fields form block.

I tried to solve the problem to allow to use of multiple translations_fields form blocks for the same translation, and surprisingly it works but is still experimental, furthermore, there are more design problems derived from this. So, I think the faster option is to move the main_link_text to the current translation_fields form block. See screenshot below:

Captura de pantalla 2021-05-26 a las 16 19 01

As you can see I had to move the voting style and currency fields below main_link fields.

I uploaded a copy of this branch here with a commit with possible fixes.

Here is the experimental PR to allow to have multiple translations_fields blocks for the same object.

How it looks like keeping original field positions
Captura de pantalla 2021-05-26 a las 14 55 22

@taitus taitus assigned Senen and unassigned Senen Jun 7, 2021
Consul Democracy automation moved this from Reviewing to Testing Jun 8, 2021
Senen and others added 4 commits June 9, 2021 16:03
As the are much faster.

Keep a system spec to check the component is called from the view.
This description of the current phase is already being displayed on the same page
in the section "Participatory budgets phases"
- Allow to define a link (text and url) on budget form for render on the budget
header.
- Improve styles

Co-authored-by: Senén Rodero Rodríguez <senenrodero@gmail.com>
@javierm javierm merged commit 297a3b4 into master Jun 9, 2021
Consul Democracy automation moved this from Testing to Release 1.4.0 Jun 9, 2021
@javierm javierm deleted the improve-budget-header branch June 9, 2021 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants