Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow attaching an image to budgets #4502

Merged
merged 1 commit into from
Jun 9, 2021
Merged

Allow attaching an image to budgets #4502

merged 1 commit into from
Jun 9, 2021

Conversation

taitus
Copy link
Member

@taitus taitus commented May 6, 2021 •
edited
Loading

References

Visual Changes

  • Frontend
    Captura de pantalla 2021-05-06 a las 15 43 45

  • Backend
    Captura de pantalla 2021-05-06 a las 15 42 04

Notes

First merge #4501

@taitus taitus self-assigned this May 6, 2021
@taitus taitus added the Budgets label May 6, 2021
@taitus taitus added this to Reviewing in Consul Democracy via automation May 6, 2021
@taitus taitus requested a review from Senen May 6, 2021 14:54
@taitus taitus changed the base branch from master to improve-budget-header May 6, 2021 14:55
@taitus taitus moved this from Reviewing to Doing in Consul Democracy May 7, 2021
@taitus taitus force-pushed the budget-image branch 2 times, most recently from f1fb90f to 50029eb Compare May 10, 2021 08:31
@taitus taitus moved this from Doing to Reviewing in Consul Democracy May 10, 2021
@taitus taitus mentioned this pull request May 11, 2021
Merged
@Senen Senen mentioned this pull request May 26, 2021
Closed
Senen
Senen reviewed May 27, 2021
View reviewed changes
Copy link
Member

@Senen Senen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @taitus,

I found some missing specs. So here you have a copy of your branch with a commit with a few fixes. I'm not pretty convinced about all of them, so please, let me know what you think. Maybe the only we really need is the missing specs.

@taitus taitus changed the base branch from improve-budget-header to budget-steps June 4, 2021 13:57
@taitus taitus changed the base branch from budget-steps to improve-budget-header June 4, 2021 14:05
Consul Democracy automation moved this from Reviewing to Testing Jun 8, 2021
@javierm javierm changed the title Ability to attach an image to budgets Allow attaching an image to budgets Jun 8, 2021
@taitus taitus force-pushed the improve-budget-header branch 2 times, most recently from 38a6338 to d78f2e0 Compare June 9, 2021 17:17
Base automatically changed from improve-budget-header to master June 9, 2021 17:50
@microweb10 @decabeza @taitus
Ability to attach an image to budgets
dcad390 
Co-authored-by: decabeza <alberto@decabeza.es>
@javierm javierm merged commit faf5ebf into master Jun 9, 2021
Consul Democracy automation moved this from Testing to Release 1.4.0 Jun 9, 2021
@javierm javierm deleted the budget-image branch June 9, 2021 23:21
@javierm javierm mentioned this pull request Oct 14, 2021
Merged
@javierm javierm added Admin and removed Admin labels Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@Senen Senen Senen approved these changes

Assignees

@Senen Senen

@taitus taitus

Labels
Budgets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@taitus @Senen @javierm @microweb10