Render investments list when budget has multiple headings #4594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taitus
force-pushed
the
unify-budget-views
branch
from
724194d
to
51911bb
Compare
taitus
changed the title
javierm
force-pushed
the
unify-budget-views
branch
2 times, most recently
from
44ab41a
to
185b0de
Compare
javierm
force-pushed
the
unify-budget-views
branch
3 times, most recently
from
d833ffd
to
9fd68be
Compare
In general, slow system tests requiring no interaction from the user are good candidates to be moved to component tests because component tests are much faster. In this case, the system tests were also updating the database after starting the browser, which might cause concurrency issues. We could split the test and have one system test per phase, but IMHO there's no need. We're still having a couple of system tests for the happy path, in order to make sure users actually see the list of investments.
We make this change to unify the index/show budget pages. This way both single and multiple budgets will render the investments list component.
This way it'll be easier to reuse its main properties.
The budget header was supposed to be huge, but only in the participatory budgets index or show actions. It was still huge, with plenty of empty space, when there was no budget, or in the "submit my ballot" and "select a heading" pages.
javierm
approved these changes
Aug 9, 2021
javierm
force-pushed
the
unify-budget-views
branch
from
9fd68be
to
9aa4683
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
javierm
force-pushed
the
unify-budget-views
branch
4 times, most recently
from
6113a77
to
4a9aae9
Compare
When render the investment list component with the link "see all investments", now we redirect to groups index page when a budget has multiple headings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Related PR's: #4198 #4507
Objectives
Render investments list component in all budgets types:
Visual Changes