This repository has been archived by the owner on Jun 10, 2020. It is now read-only.
Job Api #2
Merged
Job Api #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/ContactHub.php
Outdated
| * @param array $job | ||
| * @return array | ||
| */ | ||
| public function updateJob($customerId, array $job) |
There was a problem hiding this comment.
può aver senso essere più espliciti e passare una cosa tipo
public function updateJob($customerId, $jobId, array $job)
che ne pensi?
There was a problem hiding this comment.
Sì, effettivamente sull'update del job passare l'id come argomento in modo da renderlo più esplicito mi piace. 👍
There was a problem hiding this comment.
ho visto nelle altre PR che sei stato coerente, quindi se tiriamo fuori l'id in questa chiamata andrebbe fatto anche per le altre simili... le altre sdk che approccio hanno tenuto?
There was a problem hiding this comment.
Le altre SDK non hanno estratto l'id. Però preferirei continuare a passarlo come argomento. Te che dici?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.