Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): add libpq-dev #30

Closed
wants to merge 1 commit into from
Closed

fix(python): add libpq-dev #30

wants to merge 1 commit into from

Conversation

rarkins
Copy link
Member

@rarkins rarkins commented Apr 10, 2021

Adds libpq when python is installed, as per renovatebot/renovate#9485 (comment)

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This packages are not installed when prebuild python is used.

@rarkins
Copy link
Member Author

rarkins commented Apr 10, 2021

What do you recommend then? I was thinking to use it for python only unless / until we heard otherwise

@viceice
Copy link
Member

viceice commented Apr 10, 2021

This need some refactoring, so it will always install that package if it is missing an we are installing as root.

@rarkins
Copy link
Member Author

rarkins commented Apr 9, 2022

@viceice what are your thoughts on adding this to our python images? More context here: renovatebot/renovate#14596

@viceice
Copy link
Member

viceice commented Apr 9, 2022

ok, we can do that. but not 100% sure it's enough.

maybe some bindings are not compiled on our python, so we should also add a test case here.

@viceice viceice mentioned this pull request May 9, 2022
4 tasks
@MarkusH
Copy link

MarkusH commented Nov 10, 2022

Is there any chance we can get libpq-dev into the renovate/renovate Docker image? What would be needed to get this happening? And is there a way to help out with that?

@viceice
Copy link
Member

viceice commented Dec 21, 2022

doesn't work that way

@viceice viceice closed this Dec 21, 2022
@viceice viceice deleted the fix/libpq-dev branch January 2, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants