don't use deprecated stub function from koji #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjmodi
approved these changes
Nov 10, 2022
rcerven
force-pushed
the
stub_depre
branch
2 times, most recently
from
ca23a03
to
d81b263
Compare
MartinBasti
reviewed
Nov 11, 2022
koji-containerbuild.spec
Outdated
Comment on lines
66
to
67
| %endif | ||
| # with_python3 |
There was a problem hiding this comment.
Suggested change
| %endif | |
| # with_python3 | |
| # end with_python3 | |
| %endif |
and you know my opinion about unrelated changes in the same commit :)
There was a problem hiding this comment.
changed and added in separate commit
* CLOUDBLD-12400 Signed-off-by: Robert Cerven <rcerven@redhat.com>
Signed-off-by: Robert Cerven <rcerven@redhat.com>
mkosiarc
approved these changes
Nov 14, 2022
|
rn updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Robert Cerven rcerven@redhat.com
Maintainers will complete the following section