Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support psi #308

Merged
merged 1 commit into from
Dec 21, 2023
Merged

support psi #308

merged 1 commit into from
Dec 21, 2023

Conversation

zouyee
Copy link
Contributor

@zouyee zouyee commented Nov 24, 2023 •
edited
Loading

@zouyee zouyee marked this pull request as draft November 24, 2023 08:05
@zouyee zouyee mentioned this pull request Nov 28, 2023
Closed
@zouyee zouyee force-pushed the main branch 2 times, most recently from f873e57 to a934ff5 Compare December 2, 2023 00:06
@zouyee zouyee marked this pull request as ready for review December 2, 2023 00:07
@zouyee
Copy link
Contributor Author

zouyee commented Dec 2, 2023 •
edited
Loading

@fuweid PTAL

@zouyee
Copy link
Contributor Author

zouyee commented Dec 5, 2023

@dmcgowan PTAL

@samuelkarp
Copy link
Member

Can you rebase this on the tip of main and remove the merge commit in the middle?

@zouyee
Copy link
Contributor Author

zouyee commented Dec 6, 2023

Can you rebase this on the tip of main and remove the merge commit in the middle?

done

fuweid
fuweid reviewed Dec 8, 2023
View reviewed changes
cgroup2/utils.go Show resolved Hide resolved
cgroup2/utils.go Outdated Show resolved Hide resolved
cgroup2/utils_test.go Outdated Show resolved Hide resolved
fuweid
fuweid reviewed Dec 11, 2023
View reviewed changes
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically, it looks good.
But, would you please squash into one commit and add two unit tests for Stats to cover PSI? Thanks

@zouyee
Copy link
Contributor Author

zouyee commented Dec 12, 2023

Basically, it looks good. But, would you please squash into one commit and add two unit tests for Stats to cover PSI? Thanks

done

fuweid
fuweid reviewed Dec 13, 2023
View reviewed changes
cgroup2/utils.go Outdated Show resolved Hide resolved
fuweid
fuweid approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zouyee
support psi
8858916 
Signed-off-by: zouyee <zouyee1989@gmail.com>
@zouyee zouyee requested a review from fuweid December 14, 2023 02:44
fuweid
fuweid approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zouyee
Copy link
Contributor Author

zouyee commented Dec 15, 2023

@samuelkarp ping

@fuweid fuweid merged commit 00f6296 into containerd:main Dec 21, 2023
8 checks passed
@zouyee zouyee mentioned this pull request Dec 28, 2023
Closed
@KimMachineGun KimMachineGun mentioned this pull request Jan 3, 2024
Merged
@pacoxu pacoxu mentioned this pull request Jul 18, 2024
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@fuweid fuweid fuweid approved these changes

@samuelkarp samuelkarp Awaiting requested review from samuelkarp

@AkihiroSuda AkihiroSuda Awaiting requested review from AkihiroSuda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose Pressure Stall Information (PSI) metrics
4 participants
@zouyee @samuelkarp @dmcgowan @fuweid