Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go-systemd dep for CI testing #66

Merged
merged 1 commit into from
Nov 1, 2018

Conversation

crosbymichael
Copy link
Member

The underlying package changed and we need to depend on a specific
version now for testing with the CI

Signed-off-by: Michael Crosby crosbymichael@gmail.com

@crosbymichael
Copy link
Member Author

yah! finally travis wakes up

The underlying package changed and we need to depend on a specific
version now for testing with the CI

Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
@codecov-io
Copy link

codecov-io commented Nov 1, 2018

Codecov Report

Merging #66 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #66   +/-   ##
======================================
  Coverage    13.6%   13.6%           
======================================
  Files          23      23           
  Lines        4528    4528           
======================================
  Hits          616     616           
  Misses       3797    3797           
  Partials      115     115
Impacted Files Coverage Δ
subsystem.go 60.71% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e94a83...ab9ec0e. Read the comment docs.

@crosbymichael
Copy link
Member Author

victory @estesp !

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@crosbymichael crosbymichael merged commit 965bb1d into containerd:master Nov 1, 2018
@crosbymichael crosbymichael deleted the systemdci branch November 1, 2018 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants