-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/1.5] vendor: golang.org/x/sys v0.0.0-20220722155257-8c9f86f7a55f #7515
Conversation
Skipping CI for Draft Pull Request. |
…a55f Taking the same version as used in the 1.6 branch from 6ee5bb7 golang/sys@33da011...8c9f86f Older versions appear to be failing on macOS with go1.18: Error: ../../../go/pkg/mod/golang.org/x/sys@v0.0.0-20201009025420-dfb3f7c4e634/unix/syscall_darwin.1_13.go:29:3: //go:linkname must refer to declared function or variable Error: ../../../go/pkg/mod/golang.org/x/sys@v0.0.0-20201009025420-dfb3f7c4e634/unix/zsyscall_darwin_amd64.1_13.go:27:3: //go:linkname must refer to declared function or variable Error: ../../../go/pkg/mod/golang.org/x/sys@v0.0.0-20201009025420-dfb3f7c4e634/unix/zsyscall_darwin_amd64.1_13.go:40:3: //go:linkname must refer to declared function or variable Error: ../../../go/pkg/mod/golang.org/x/sys@v0.0.0-20201009025420-dfb3f7c4e634/unix/zsyscall_darwin_amd64.go:28:3: //go:linkname must refer to declared function or variable Error: ../../../go/pkg/mod/golang.org/x/sys@v0.0.0-20201009025420-dfb3f7c4e634/unix/zsyscall_darwin_amd64.go:43:3: //go:linkname must refer to declared function or variable ... Error: ../../../go/pkg/mod/golang.org/x/sys@v0.0.0-20201009025420-dfb3f7c4e634/unix/zsyscall_darwin_amd64.go:121:3: too many errors Error: Process completed with exit code 2. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
9dbedb2
to
ac382a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
So, initially this PR failed, and I found that it was because |
Hm... not sure if this fixes the issue #7476 (comment) (although updating shouldn't be a bad thing to do) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Taking the same version as used in the 1.6 branch from 6ee5bb7
golang/sys@33da011...8c9f86f
Older versions appear to be failing on macOS with go1.18: