fs/stat: add FreeBSD, and cleanup some nolint-comments #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This forwards the build-tag from containerd/containerd: containerd/containerd@4c47fe0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Unlike comments for "humans", nolint comments should not have a leading whitespace. Also combined some comments, and renamed local variables so that we don't have to suppress linting warnings for those. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
AkihiroSuda
approved these changes
Jun 22, 2021
samuelkarp
reviewed
Jun 22, 2021
|
Thanks, Sam; thought it was "bsd" related, so possibly of interest to you 🤗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to containerd/containerd#4579
this forward-ports the changes from containerd/containerd#4579 to this package, so that we can deprecate/remove the copy of these utilities from containerd (and recommend users to use the variant from this repository instead).