Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fmt.Errorf("%w", err) on err == nil #187

Merged
merged 1 commit into from
Oct 14, 2021

Conversation

AkihiroSuda
Copy link
Member

When err is nil, fmt.Errorf("....: %w", err) should not be returned

Thanks to @simonflood for reporting this in rancher-sandbox/rancher-desktop#771 (comment)

When err is nil, `fmt.Errorf("....: %w", err)` should not be returned

Reported in rancher-sandbox/rancher-desktop issue 771

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda
Copy link
Member Author

We should release v0.2.1 after merging this

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AkihiroSuda AkihiroSuda merged commit b6b5198 into containerd:main Oct 14, 2021
@AkihiroSuda
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants