Copy Windows file metadata #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabriel-samfira
force-pushed
the
copy-windows-acl
branch
from
4f0def3
to
0733775
Compare
gabriel-samfira
force-pushed
the
copy-windows-acl
branch
from
0733775
to
7de5feb
Compare
dmcgowan
reviewed
Nov 12, 2021
This change ensures that file ownership and ACLs are properly copied on Windows. Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
gabriel-samfira
force-pushed
the
copy-windows-acl
branch
from
7de5feb
to
2cd7d24
Compare
jsturtevant
reviewed
Nov 16, 2021
| // apply security info which includes SIDs not necessarily present on | ||
| // the host. | ||
| privileges := []string{winio.SeRestorePrivilege, seTakeOwnershipPrivilege} | ||
| if err := winio.EnableProcessPrivileges(privileges); err != nil { |
There was a problem hiding this comment.
Something similar is done during snapshotting:
https://github.com/containerd/containerd/blob/7758cdc09ad5c6c5e5eecdfacfa639d3cf87bdbf/snapshots/windows/windows.go#L474-L480
This was referenced Nov 22, 2021
kzys
approved these changes
Nov 30, 2021
dmcgowan
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that file ownership and Discretionary ACLs are properly preserved on Windows.