Build containerd/continuity on multiple Unix OSes #190
Conversation
kzys
force-pushed
the
netbsd
branch
3 times, most recently
from
a9dc5a3
to
cb048fa
Compare
kzys
force-pushed
the
netbsd
branch
4 times, most recently
from
170de5a
to
fbb2850
Compare
kzys
changed the title
kzys
force-pushed
the
netbsd
branch
5 times, most recently
from
6c8ca0e
to
0261229
Compare
While the .go files have multiple build tags, they haven't been tested on GitHub Actions except for FreeBSD. This change also fixes containerd#183. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
|
Other than just cross-compiling, have we done any testing on those other operating systems? (In other words: should we include build tags and thus "support" for an operating system that is not tested?) |
|
No. We technically could use GitHub Actions' macOS builder to run VirtualBox (like we do in containerd), but I haven't tried that yet. I still think this is better than what we have today. We have a bunch of build tags but the combinations are not really tested. |
|
I was going to say that it looks like openbsd and netbsd are new additions and maybe we should let compilation fail, but I see in #183 that @AkihiroSuda is trying to use continuity on netbsd already. Looks like there's already a note in the readme about support, so I think this is fine. |
|
@estesp Can you take a look? This should be okay to merge LGTM-wise. |
While the .go files have multiple build tags, they haven't been tested on
GitHub Actions except for FreeBSD.
This change also fixes #183.
Signed-off-by: Kazuyoshi Kato katokazu@amazon.com