Add type to iterate directory #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpuguy83
force-pushed
the
dir_iter
branch
4 times, most recently
from
e0a78ae
to
67e1035
Compare
This prevents reading from directory from allocating an unbounded slice at the cost of potentially having to read more than once. It also prevents unccessary allocation in cases where an error occurs handling the file type. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
AkihiroSuda
approved these changes
Aug 19, 2023
|
Let's make a new release after merging this |
dcantah
approved these changes
Oct 18, 2023
dmcgowan
approved these changes
Oct 18, 2023
dmcgowan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents reading from directory from allocating an unbounded slice at the cost of potentially having to read more than once.
It also prevents unccessary allocation in cases where an error occurs handling the file type.