Build on ppc64(le), s390x #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stevvooe PTAL |
|
LGTM These probably need support. cc @estesp |
|
@sul3n3t I'd like to get a little feedback to know if we need particular "road map" issues. |
|
A quick spot check seems to show these syscalls (the xattr family of calls) are available in current Golang implementation for ppc64le and s390x (for example: https://github.com/golang/go/blob/master/src/syscall/zsyscall_linux_ppc64le.go) So; obviously this PR is one way to get a building project for those architectures, but seems the long term solution is an update to the generate scripts to add the pairs for |
This was referenced May 2, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These stubs will allow compilation on ppc64, ppc64le, and s390x architectures.