Skip to content
This repository has been archived by the owner on Mar 9, 2022. It is now read-only.

Add --version flag. #8

Closed
Random-Liu opened this issue Apr 17, 2017 · 2 comments
Closed

Add --version flag. #8

Random-Liu opened this issue Apr 17, 2017 · 2 comments
Labels
kind/help-wanted

Comments

@Random-Liu
Copy link
Member

Add cri-containerd version.

We should version cri-containerd based on the repo tag and commit number. The version will be used:

  1. As part of the name when building a release package or any docker image in the future.
  2. As part of --version output.

Refer kubernetes/node-problem-detector#71.
@Random-Liu Random-Liu changed the title Add --version option. Add --version flag. Apr 17, 2017
@cmluciano
Copy link
Contributor

I will take a stab at a PR

@Random-Liu
Copy link
Member Author

@cmluciano Sure. Feel free to pick up this! Thanks a lot! :)

cmluciano pushed a commit to cmluciano/cri-containerd that referenced this issue Apr 18, 2017
Add containerdVersion flag
c559f7b 
Add version flag that only prints the static version for the binary.

This commit does not include build details for containers since
Makefile does not build them.

Closes containerd#8
@cmluciano cmluciano mentioned this issue Apr 18, 2017
Merged
cmluciano pushed a commit to cmluciano/cri-containerd that referenced this issue Apr 19, 2017
Add containerdVersion flag
f246438 
Add version flag that only prints the static version for the binary.

This commit does not include build details for containers since
Makefile does not build them.

Closes containerd#8
cmluciano pushed a commit to cmluciano/cri-containerd that referenced this issue Apr 20, 2017
Add containerdVersion flag
9e1e771 
Add version flag that only prints the static version for the binary.

This commit does not include build details for containers since
Makefile does not build them.

Closes containerd#8
cmluciano pushed a commit to cmluciano/cri-containerd that referenced this issue Apr 21, 2017
Add containerdVersion flag
df6a1cc 
Add version flag that only prints the static version for the binary.

This commit does not include build details for containers since
Makefile does not build them.

Closes containerd#8
cmluciano pushed a commit to cmluciano/cri-containerd that referenced this issue Apr 24, 2017
Add containerdVersion flag
71a2137 
Add version flag that only prints the static version for the binary.

This commit does not include build details for containers since
Makefile does not build them.

Closes containerd#8

Signed-off-by: Christopher M. Luciano <cmluciano@us.ibm.com>
cmluciano pushed a commit to cmluciano/cri-containerd that referenced this issue Apr 24, 2017
Add containerdVersion flag
992996f 
Add version flag that only prints the static version for the binary.

This commit does not include build details for containers since
Makefile does not build them.

Closes containerd#8

Signed-off-by: Christopher M. Luciano <cmluciano@us.ibm.com>
cmluciano pushed a commit to cmluciano/cri-containerd that referenced this issue Apr 24, 2017
Add containerdVersion flag
15547ed 
Add version flag that only prints the static version for the binary.

This commit does not include build details for containers since
Makefile does not build them.

Closes containerd#8

Signed-off-by: Christopher M. Luciano <cmluciano@us.ibm.com>
cmluciano pushed a commit to cmluciano/cri-containerd that referenced this issue Apr 24, 2017
Add containerdVersion flag
a770afb 
Add version flag that only prints the static version for the binary.

This commit does not include build details for containers since
Makefile does not build them.

Closes containerd#8

Signed-off-by: Christopher M. Luciano <cmluciano@us.ibm.com>
cmluciano pushed a commit to cmluciano/cri-containerd that referenced this issue Apr 24, 2017
Add containerdVersion flag
659364b 
Add version flag that only prints the static version for the binary.

This commit does not include build details for containers since
Makefile does not build them.

Closes containerd#8

Signed-off-by: Christopher M. Luciano <cmluciano@us.ibm.com>
cmluciano pushed a commit to cmluciano/cri-containerd that referenced this issue Apr 24, 2017
Add containerdVersion flag
f17d409 
Add version flag that only prints the static version for the binary.

This commit does not include build details for containers since
Makefile does not build them.

Closes containerd#8

Signed-off-by: Christopher M. Luciano <cmluciano@us.ibm.com>
cmluciano pushed a commit to cmluciano/cri-containerd that referenced this issue Apr 24, 2017
Add containerdVersion flag
c31ed30 
Add version flag that only prints the static version for the binary.

This commit does not include build details for containers since
Makefile does not build them.

Closes containerd#8

Signed-off-by: Christopher M. Luciano <cmluciano@us.ibm.com>
cmluciano pushed a commit to cmluciano/cri-containerd that referenced this issue Apr 24, 2017
Add containerdVersion flag
683fd7f 
Add version flag that only prints the static version for the binary.

This commit does not include build details for containers since
Makefile does not build them.

Closes containerd#8

Signed-off-by: Christopher M. Luciano <cmluciano@us.ibm.com>
lanchongyizu pushed a commit to lanchongyizu/cri-containerd that referenced this issue Sep 3, 2017
Add containerdVersion flag
be7e613 
Add version flag that only prints the static version for the binary.

This commit does not include build details for containers since
Makefile does not build them.

Closes containerd#8

Signed-off-by: Christopher M. Luciano <cmluciano@us.ibm.com>
adelina-t pushed a commit to adelina-t/cri that referenced this issue Jun 20, 2019
@jterry75
Merge pull request containerd#8 from SaswatB/windows_port
34231c1 
Added path formatting for path in mounts
dcantah pushed a commit to dcantah/cri that referenced this issue Jan 7, 2022
@anmaxvl
Merge pull request containerd#8 from anmaxvl/cherry-pick-filter-ineri…
5ef5b62 
…ted-labels

Filter snapshotter labels passed to WithNewSnapshot
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
kind/help-wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cmluciano @Random-Liu