nerdctl rmi can be broken by using tag names with repo short sha #3016
Assignees
Labels
bug
Something isn't working
Comments
Merged
yankay
added
bug
|
Can we reopen? |
|
@yankay @AkihiroSuda can we reopen this? |
|
Hi, team I want to work on this issue, so could you assign this ? |
haytok
added a commit
to haytok/nerdctl
that referenced
this issue
Oct 8, 2024
… of another images.
"nerdctl rmi <REPOSITORY>" can be run to delete the target images.
However, at the current implementation, the deletion fails when images
names are the short digest ids of another images.
The specific behavior is described below, which is how it works in the
current implementation.
First, suppose there are alpine and busybox images.
```
> nerdctl images
REPOSITORY TAG IMAGE ID CREATED PLATFORM SIZE BLOB SIZE
busybox latest 768e5c6f5cb6 3 seconds ago linux/arm64 4.092MB 1.845MB
alpine latest beefdbd8a1da 11 seconds ago linux/arm64 10.46MB 4.09MB
```
Then, we tag the alpine image using digest id of the busybox image.
```
> nerdctl tag alpine $(dn inspect busybox | jq -rc .[0].RepoDigests[0] | awk -F':' '{print substr($2, 1, 8)}')
> nerdctl images
REPOSITORY TAG IMAGE ID CREATED PLATFORM SIZE BLOB SIZE
768e5c6f latest beefdbd8a1da 4 seconds ago linux/arm64 10.46MB 4.09MB
busybox latest 768e5c6f5cb6 22 hours ago linux/arm64 4.092MB 1.845MB
alpine latest beefdbd8a1da 22 hours ago linux/arm64 10.46MB 4.09MB
```
In this situation, running 'nerdctl rmi "$(dn inspect busybox | jq -rc .[0].RepoDigests[0] | awk -F':' '{print substr($2, 1, 8)}')"'
will fail to remove the image.
The details of the error are as follows.
```
> nerdctl rmi "$(dn inspect busybox | jq -rc .[0].RepoDigests[0] | awk -F':' '{print substr($2, 1, 8)}')"
FATA[0000] 1 errors:
multiple IDs found with provided prefix: 768e5c6f
```
This issue is reported in the following issue.
- containerd#3016
Therefore, this pull request modifies this so that images can be deleted
with "nerdctl rmi <short digest id of another image>" when images names are
the short digest ids of another images.
Signed-off-by: Hayato Kiwata <haytok@amazon.co.jp>
haytok
added a commit
to haytok/nerdctl
that referenced
this issue
Oct 16, 2024
… of another images.
"nerdctl rmi <REPOSITORY>" can be run to delete the target images.
However, at the current implementation, the deletion fails when images
names are the short digest ids of another images.
The specific behavior is described below, which is how it works in the
current implementation.
First, suppose there are alpine and busybox images.
```
> nerdctl images
REPOSITORY TAG IMAGE ID CREATED PLATFORM SIZE BLOB SIZE
busybox latest 768e5c6f5cb6 3 seconds ago linux/arm64 4.092MB 1.845MB
alpine latest beefdbd8a1da 11 seconds ago linux/arm64 10.46MB 4.09MB
```
Then, we tag the alpine image using digest id of the busybox image.
```
> nerdctl tag alpine $(dn inspect busybox | jq -rc .[0].RepoDigests[0] | awk -F':' '{print substr($2, 1, 8)}')
> nerdctl images
REPOSITORY TAG IMAGE ID CREATED PLATFORM SIZE BLOB SIZE
768e5c6f latest beefdbd8a1da 4 seconds ago linux/arm64 10.46MB 4.09MB
busybox latest 768e5c6f5cb6 22 hours ago linux/arm64 4.092MB 1.845MB
alpine latest beefdbd8a1da 22 hours ago linux/arm64 10.46MB 4.09MB
```
In this situation, running 'nerdctl rmi "$(dn inspect busybox | jq -rc .[0].RepoDigests[0] | awk -F':' '{print substr($2, 1, 8)}')"'
will fail to remove the image.
The details of the error are as follows.
```
> nerdctl rmi "$(dn inspect busybox | jq -rc .[0].RepoDigests[0] | awk -F':' '{print substr($2, 1, 8)}')"
FATA[0000] 1 errors:
multiple IDs found with provided prefix: 768e5c6f
```
This issue is reported in the following issue.
- containerd#3016
Therefore, this pull request modifies this so that images can be deleted
with "nerdctl rmi <short digest id of another image>" when images names are
the short digest ids of another images.
Signed-off-by: Hayato Kiwata <haytok@amazon.co.jp>
haytok
added a commit
to haytok/nerdctl
that referenced
this issue
Oct 17, 2024
… of another images.
"nerdctl rmi <REPOSITORY>" can be run to delete the target images.
However, at the current implementation, the deletion fails when images
names are the short digest ids of another images.
The specific behavior is described below, which is how it works in the
current implementation.
First, suppose there are alpine and busybox images.
```
> nerdctl images
REPOSITORY TAG IMAGE ID CREATED PLATFORM SIZE BLOB SIZE
busybox latest 768e5c6f5cb6 3 seconds ago linux/arm64 4.092MB 1.845MB
alpine latest beefdbd8a1da 11 seconds ago linux/arm64 10.46MB 4.09MB
```
Then, we tag the alpine image using digest id of the busybox image.
```
> nerdctl tag alpine $(dn inspect busybox | jq -rc .[0].RepoDigests[0] | awk -F':' '{print substr($2, 1, 8)}')
> nerdctl images
REPOSITORY TAG IMAGE ID CREATED PLATFORM SIZE BLOB SIZE
768e5c6f latest beefdbd8a1da 4 seconds ago linux/arm64 10.46MB 4.09MB
busybox latest 768e5c6f5cb6 22 hours ago linux/arm64 4.092MB 1.845MB
alpine latest beefdbd8a1da 22 hours ago linux/arm64 10.46MB 4.09MB
```
In this situation, running 'nerdctl rmi "$(dn inspect busybox | jq -rc .[0].RepoDigests[0] | awk -F':' '{print substr($2, 1, 8)}')"'
will fail to remove the image.
The details of the error are as follows.
```
> nerdctl rmi "$(dn inspect busybox | jq -rc .[0].RepoDigests[0] | awk -F':' '{print substr($2, 1, 8)}')"
FATA[0000] 1 errors:
multiple IDs found with provided prefix: 768e5c6f
```
This issue is reported in the following issue.
- containerd#3016
Therefore, this pull request modifies this so that images can be deleted
with "nerdctl rmi <short digest id of another image>" when images names are
the short digest ids of another images.
Signed-off-by: Hayato Kiwata <haytok@amazon.co.jp>
haytok
added a commit
to haytok/nerdctl
that referenced
this issue
Oct 19, 2024
… of another images.
"nerdctl rmi <REPOSITORY>" can be run to delete the target images.
However, at the current implementation, the deletion fails when images
names are the short digest ids of another images.
The specific behavior is described below, which is how it works in the
current implementation.
First, suppose there are alpine and busybox images.
```
> nerdctl images
REPOSITORY TAG IMAGE ID CREATED PLATFORM SIZE BLOB SIZE
busybox latest 768e5c6f5cb6 3 seconds ago linux/arm64 4.092MB 1.845MB
alpine latest beefdbd8a1da 11 seconds ago linux/arm64 10.46MB 4.09MB
```
Then, we tag the alpine image using digest id of the busybox image.
```
> nerdctl tag alpine $(dn inspect busybox | jq -rc .[0].RepoDigests[0] | awk -F':' '{print substr($2, 1, 8)}')
> nerdctl images
REPOSITORY TAG IMAGE ID CREATED PLATFORM SIZE BLOB SIZE
768e5c6f latest beefdbd8a1da 4 seconds ago linux/arm64 10.46MB 4.09MB
busybox latest 768e5c6f5cb6 22 hours ago linux/arm64 4.092MB 1.845MB
alpine latest beefdbd8a1da 22 hours ago linux/arm64 10.46MB 4.09MB
```
In this situation, running 'nerdctl rmi "$(dn inspect busybox | jq -rc .[0].RepoDigests[0] | awk -F':' '{print substr($2, 1, 8)}')"'
will fail to remove the image.
The details of the error are as follows.
```
> nerdctl rmi "$(dn inspect busybox | jq -rc .[0].RepoDigests[0] | awk -F':' '{print substr($2, 1, 8)}')"
FATA[0000] 1 errors:
multiple IDs found with provided prefix: 768e5c6f
```
This issue is reported in the following issue.
- containerd#3016
Therefore, this pull request modifies this so that images can be deleted
with "nerdctl rmi <short digest id of another image>" when images names are
the short digest ids of another images.
Signed-off-by: Hayato Kiwata <haytok@amazon.co.jp>
haytok
added a commit
to haytok/nerdctl
that referenced
this issue
Oct 19, 2024
… of another images.
"nerdctl rmi <REPOSITORY>" can be run to delete the target images.
However, at the current implementation, the deletion fails when images
names are the short digest ids of another images.
The specific behavior is described below, which is how it works in the
current implementation.
First, suppose there are alpine and busybox images.
```
> nerdctl images
REPOSITORY TAG IMAGE ID CREATED PLATFORM SIZE BLOB SIZE
busybox latest 768e5c6f5cb6 3 seconds ago linux/arm64 4.092MB 1.845MB
alpine latest beefdbd8a1da 11 seconds ago linux/arm64 10.46MB 4.09MB
```
Then, we tag the alpine image using digest id of the busybox image.
```
> nerdctl tag alpine $(dn inspect busybox | jq -rc .[0].RepoDigests[0] | awk -F':' '{print substr($2, 1, 8)}')
> nerdctl images
REPOSITORY TAG IMAGE ID CREATED PLATFORM SIZE BLOB SIZE
768e5c6f latest beefdbd8a1da 4 seconds ago linux/arm64 10.46MB 4.09MB
busybox latest 768e5c6f5cb6 22 hours ago linux/arm64 4.092MB 1.845MB
alpine latest beefdbd8a1da 22 hours ago linux/arm64 10.46MB 4.09MB
```
In this situation, running 'nerdctl rmi "$(dn inspect busybox | jq -rc .[0].RepoDigests[0] | awk -F':' '{print substr($2, 1, 8)}')"'
will fail to remove the image.
The details of the error are as follows.
```
> nerdctl rmi "$(dn inspect busybox | jq -rc .[0].RepoDigests[0] | awk -F':' '{print substr($2, 1, 8)}')"
FATA[0000] 1 errors:
multiple IDs found with provided prefix: 768e5c6f
```
This issue is reported in the following issue.
- containerd#3016
Therefore, this pull request modifies this so that images can be deleted
with "nerdctl rmi <short digest id of another image>" when images names are
the short digest ids of another images.
Signed-off-by: Hayato Kiwata <haytok@amazon.co.jp>
haytok
added a commit
to haytok/nerdctl
that referenced
this issue
Oct 19, 2024
… of another images.
"nerdctl rmi <REPOSITORY>" can be run to delete the target images.
However, at the current implementation, the deletion fails when images
names are the short digest ids of another images.
The specific behavior is described below, which is how it works in the
current implementation.
First, suppose there are alpine and busybox images.
```
> nerdctl images
REPOSITORY TAG IMAGE ID CREATED PLATFORM SIZE BLOB SIZE
busybox latest 768e5c6f5cb6 3 seconds ago linux/arm64 4.092MB 1.845MB
alpine latest beefdbd8a1da 11 seconds ago linux/arm64 10.46MB 4.09MB
```
Then, we tag the alpine image using digest id of the busybox image.
```
> nerdctl tag alpine $(dn inspect busybox | jq -rc .[0].RepoDigests[0] | awk -F':' '{print substr($2, 1, 8)}')
> nerdctl images
REPOSITORY TAG IMAGE ID CREATED PLATFORM SIZE BLOB SIZE
768e5c6f latest beefdbd8a1da 4 seconds ago linux/arm64 10.46MB 4.09MB
busybox latest 768e5c6f5cb6 22 hours ago linux/arm64 4.092MB 1.845MB
alpine latest beefdbd8a1da 22 hours ago linux/arm64 10.46MB 4.09MB
```
In this situation, running 'nerdctl rmi "$(dn inspect busybox | jq -rc .[0].RepoDigests[0] | awk -F':' '{print substr($2, 1, 8)}')"'
will fail to remove the image.
The details of the error are as follows.
```
> nerdctl rmi "$(dn inspect busybox | jq -rc .[0].RepoDigests[0] | awk -F':' '{print substr($2, 1, 8)}')"
FATA[0000] 1 errors:
multiple IDs found with provided prefix: 768e5c6f
```
This issue is reported in the following issue.
- containerd#3016
Therefore, this pull request modifies this so that images can be deleted
with "nerdctl rmi <short digest id of another image>" when images names are
the short digest ids of another images.
Signed-off-by: Hayato Kiwata <haytok@amazon.co.jp>
|
Fixed by #3519 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
When an image uses a tag that is a short version of another (unrelated) image repo sha, nerdctl rmi will break down.
This is another aspect of one of the many issues with our current image lookup implementation.
Steps to reproduce the issue
Describe the results you received and expected
Should have just worked and removed the tagged version of alpine.
What version of nerdctl are you using?
1.7.6
Are you using a variant of nerdctl? (e.g., Rancher Desktop)
None
Host information
No response
The text was updated successfully, but these errors were encountered: