Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support build args without explicit value #1417

Merged
merged 1 commit into from
Oct 19, 2022

Commits on Oct 13, 2022

  1. Support build args without explicit value

    When a build arg key is specified without an explicit value, the
    value should be taken from the corresponding environment variable
    on the host [1].
    
    When the corresponding environment variable on the host is unset,
    the build arg should be ignored [2] to avoid masking a possible default
    value specified in the Dockerfile [3]. To pass an empty string as
    build arg, use the form "VAR=" on the CLI/as an environment variable.
    
    [1]: https://docs.docker.com/engine/reference/commandline/build/#set-build-time-variables---build-arg
    [2]: https://docs.docker.com/engine/reference/commandline/run/#set-environment-variables--e---env---env-file
    [3]: moby/moby#24101
    
    Signed-off-by: Caleb Xu <calebcenter@live.com>
    alebcay committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    a9dda52 View commit details
    Browse the repository at this point in the history