Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor container inspect #1850

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Refactor container inspect #1850

merged 1 commit into from
Jan 18, 2023

Conversation

weikequ
Copy link
Contributor

@weikequ weikequ commented Jan 13, 2023 •
edited
Loading

Hey! 👋 It's my first time submitting a PR to this project, hopefully not too rough. Feedback very much encouraged!

Refactoring project from #1680

I also wasn't sure if I should add any unit tests to pkg/cmd/ for this refactor. Let me know if I should.

  • Create a file in pkg/api/types/${cmd}.go, and define the CommandOption for this command
  • Create some file in pkg/cmd/${cmd}, and move the command entry point in real into this package

@weikequ
Copy link
Contributor Author

weikequ commented Jan 14, 2023

Added sign off to fix project checks.

@AkihiroSuda AkihiroSuda added this to the v1.2.0 milestone Jan 17, 2023
djdongjin
djdongjin reviewed Jan 17, 2023
View reviewed changes
cmd/nerdctl/container_inspect.go Show resolved Hide resolved
pkg/api/types/container_types.go Outdated Show resolved Hide resolved
pkg/cmd/container/inspect.go Outdated Show resolved Hide resolved
@weikequ
Refactor container inspect
76fb67f 
Signed-off-by: Weike Qu <weikequ@amazon.com>
@weikequ
Copy link
Contributor Author

weikequ commented Jan 17, 2023

Seems like the rootless main integration test failed. Was it due to time out?

DONE 369 tests, 24 skipped, 46 failures in 1200.098s

djdongjin
djdongjin approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@djdongjin djdongjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

AkihiroSuda
AkihiroSuda approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit ded43fc into containerd:main Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@djdongjin djdongjin djdongjin approved these changes

Assignees
No one assigned
Labels
kind/refactor
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@weikequ @AkihiroSuda @djdongjin