Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Refactor the (container) pause command flagging process #1920

Merged
merged 1 commit into from
Jan 25, 2023
Merged

[Refactor] Refactor the (container) pause command flagging process #1920

merged 1 commit into from
Jan 25, 2023

Conversation

Laitr0n
Copy link
Contributor

@Laitr0n Laitr0n commented Jan 24, 2023

Part of #1680

Checklist:

  • Move pauseContainer from cmd to pkg/containerutil
  • Create a file in pkg/api/types/${cmd}_types.go, and define the CommandOption for this command
  • Create some file in pkg/cmd/${cmd}, and move the command entry point in real into this package

Signed-off-by: Laitron meetlq@outlook.com

@Laitr0n Laitr0n marked this pull request as ready for review January 24, 2023 08:20
@Laitr0n
[Refactor] Refactor the (container) pause command flagging process
72f447f 
Signed-off-by: Laitron <meetlq@outlook.com>
@Laitr0n
Copy link
Contributor Author

Laitr0n commented Jan 25, 2023 •
edited
Loading

I have resolved the conflict. @AkihiroSuda PTAL. Thanks.

@AkihiroSuda AkihiroSuda added this to the v1.2.0 milestone Jan 25, 2023
AkihiroSuda
AkihiroSuda approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit 4293ca4 into containerd:main Jan 25, 2023
@Laitr0n Laitr0n deleted the refactor_container_pause branch January 25, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@djdongjin djdongjin djdongjin approved these changes

Assignees
No one assigned
Labels
kind/refactor
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Laitr0n @AkihiroSuda @djdongjin