refactor: container list flagging process #1966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djdongjin
reviewed
Feb 3, 2023
| @@ -149,3 +149,24 @@ type ContainerExecOptions struct { | |||
| // Username or UID (format: <name|uid>[:<group|gid>]) | |||
| User string | |||
| } | |||
|
|
|||
| type ContainerListOptions struct { | |||
There was a problem hiding this comment.
Can you add a brief comment here?
| "github.com/sirupsen/logrus" | ||
| ) | ||
|
|
||
| func List(ctx context.Context, client *containerd.Client, options types.ContainerListOptions) error { |
There was a problem hiding this comment.
can you add a brief comment here?
There was a problem hiding this comment.
// List prints containers according to
options.
Since there're things other than Filters that control what containers should be printed (e.g., All, LastN, etc.), I didn't go into explaining the details. Please let me know if this works for you, thanks!
Signed-off-by: Hsing-Yu (David) Chen <davidhsingyuchen@gmail.com>
davidhsingyuchen
force-pushed
the
refactor-container-list
branch
from
9730e30
to
3eedefa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1680
pkg/api/types/${cmd}_types.go, and define the CommandOption for this commandpkg/cmd/${cmd}, and move the command entry point in real into this packageSigned-off-by: Hsing-Yu (David) Chen davidhsingyuchen@gmail.com